note added to docs for proper responsiveness when relative chart parent is inside grid or flex container#11509
Closed
DavidAshburn wants to merge 1 commit intochartjs:masterfrom
Closed
Conversation
… element is a child of a flex or grid container
LeeLenaleee
requested changes
Sep 24, 2023
Collaborator
LeeLenaleee
left a comment
LeeLenaleee
left a comment
There was a problem hiding this comment.
On mobile so can't review correctly but main point of critique i see now is all the style changes you did like params in a div on sperate lines or double quotes for strings. This is not in line with the rest of the documentation.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the relative chart parent element is inside of a flex or grid container you get weird overflows on resize unless the relative chart parent has min-width set to 0